Switch to a non-tuple based type tracking #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rw-access
force-pushed
the
feature/backport-types-cleanup
branch
from
2112d92 to
7d65796
Compare
brokensound77
approved these changes
Apr 16, 2020
| IDENT_RE = re.compile(r"^[_a-zA-Z][a-zA-Z0-9_]*$") | ||
|
|
||
|
|
||
| is_primitive = set(b.value for b in TypeHint.primitives()).__contains__ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Relates to #15 for Elasticsearch based type changes.
Details
Address some tech debt. Removed the brittle tuple-based type system and switched to something class-based. This simplifies the handling and will make future maintenance and type-based changes easier.