Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'reason' field in 'websocket.close' messages #957

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

michallowasrzechonek-silvair
Copy link
Contributor

fixes #951

@michallowasrzechonek-silvair michallowasrzechonek-silvair changed the title [WIP] Support 'reason' field in 'websocket.close' messages Support 'reason' field in 'websocket.close' messages Feb 23, 2021
Copy link
Member

@euri10 euri10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@euri10 euri10 merged commit d716ad0 into encode:master Feb 24, 2021
sthagen added a commit to sthagen/encode-uvicorn that referenced this pull request Feb 24, 2021
Support 'reason' field in 'websocket.close' messages (encode#957)
@michallowasrzechonek-silvair michallowasrzechonek-silvair deleted the websocket_close_reason branch February 28, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying reason during websocket close
2 participants