Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying reason during websocket close #951

Closed
2 tasks done
michallowasrzechonek-silvair opened this issue Feb 10, 2021 · 0 comments · Fixed by #957
Closed
2 tasks done

Allow specifying reason during websocket close #951

michallowasrzechonek-silvair opened this issue Feb 10, 2021 · 0 comments · Fixed by #957
Labels
enhancement websockets

Comments

@michallowasrzechonek-silvair
Copy link
Contributor

michallowasrzechonek-silvair commented Feb 10, 2021 •
edited
Loading

Checklist

  • There are no similar issues or pull requests for this yet.
  • I discussed this idea on the community chat and feedback is positive.

Is your feature related to a problem? Please describe.

At the moment applications can't specify the reason (see https://tools.ietf.org/html/rfc6455#section-5.5.1) when closing a websocket, just the code.

Describe the solution you would like.

After django/asgiref#235 ASGI allows applications to specify reason, so let's add support for that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement websockets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support 'reason' field in 'websocket.close' messages SilvairGit/uvicorn
2 participants
@euri10 @michallowasrzechonek-silvair