Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle URL quoting username and password components. #1159

Merged
merged 5 commits into from
Aug 11, 2020
Merged

Handle URL quoting username and password components. #1159

merged 5 commits into from
Aug 11, 2020

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Aug 10, 2020 •
edited
Loading

So that...

url = httpx.URL("https://tom%40example.org:abc123%40%20%[email protected]")
url.username == "[email protected]"
url.password == "abc123@ %"

And...

url = httpx.URL("https://example.org").copy_with(username="[email protected]", password="abc123@ %")
url == "https://tom%40example.org:abc123%40%20%[email protected]"

Closes #858
Closes #328

Need to also have a think about what exact behaviour we're expecting from .path, full_path, and .query, but can treat those separately.

@tomchristie tomchristie added the bug Something isn't working label Aug 10, 2020
jcugat
jcugat approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@jcugat jcugat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, my approval is finally green ✅

@tomchristie tomchristie merged commit 655773e into master Aug 11, 2020
@tomchristie tomchristie deleted the quote-userinfo-components branch August 11, 2020 16:18
@tomchristie tomchristie mentioned this pull request Aug 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcugat jcugat jcugat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@tomchristie @jcugat