Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept url-encoded characters in proxy authentication strings #858

Closed
lethargynavigator opened this issue Mar 10, 2020 · 1 comment · Fixed by #1159
Closed

Accept url-encoded characters in proxy authentication strings #858

lethargynavigator opened this issue Mar 10, 2020 · 1 comment · Fixed by #1159
Labels
bug Something isn't working external Root cause pending resolution in an external dependency proxies Issues related to HTTP and SOCKS proxies

Comments

@lethargynavigator
Copy link

Certain characters such as @:!#$ break proxy authentication strings when included without url-encoding them.

I'm dealing with a service account that has # in the password and httpx is unable handle this. # breaks the URI and %23 is sent literal.

Expected behavior: In requests we can url-encode these characters in the proxy strings defined within proxies dict and they will be properly decoded before sending the request.

@yeraydiazdiaz yeraydiazdiaz added the proxies Issues related to HTTP and SOCKS proxies label Mar 11, 2020
@tomchristie
Copy link
Member

Related: #328

@tomchristie tomchristie added the bug Something isn't working label Mar 11, 2020
@yeraydiazdiaz yeraydiazdiaz added the external Root cause pending resolution in an external dependency label May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Root cause pending resolution in an external dependency proxies Issues related to HTTP and SOCKS proxies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants