-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Django/Python Testing Combinations #3405
Update Django/Python Testing Combinations #3405
Conversation
Dropping 3.2 I get, not sure we gain anything dropping 3.3, probably be our baseline for a long while. |
Oh wait, ignore that. |
Top link above |
Yup |
py32: python3.2 | ||
py33: python3.3 | ||
py34: python3.4 | ||
py35: python3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like Travis doesn't yet have Python 3.5 available. See build here:
$ tox -e $TOX_ENV
GLOB sdist-make: /home/travis/build/tomchristie/django-rest-framework/setup.py
py35-djangomaster create: /home/travis/build/tomchristie/django-rest-framework/.tox/py35-djangomaster
ERROR: InterpreterNotFound: python3.5
It's in allowed_failures
but I will investigate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carltongibson IMHO it's good enough as it stands. We might reconsider that once 1.9 is out.
|
OK. I'll redo the PR against 3.3 — and add the README/doc notes. I don't mind which of the changes we want here. My personal view is to follow Django's supported versions, unless some commercial body wants to fund extra. But I'm not religious about that. |
Re the Django 1.5/1.6 thing, I just had this conversation on django-appconf. It's more or less what I think:
|
Probably stuff to remove in compat too. I'd say supporting a fixed number of Django versions would be reasonable. (Either 3 or 4) |
I'll reopen this against 3.3. |
In three parts: