Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Django/Python Testing Combinations #3405

Closed

Conversation

carltongibson
Copy link
Collaborator

In three parts:

  • Remove Python 3.2 and 3.3. from Django 1.9 tests See here
  • Add Python 3.5 against 1.9
  • Remove Django 1.5 and 1.6 Not Supported

@tomchristie
Copy link
Member

Dropping 3.2 I get, not sure we gain anything dropping 3.3, probably be our baseline for a long while.

@tomchristie
Copy link
Member

Oh wait, ignore that.

@carltongibson
Copy link
Collaborator Author

We’ve dropped support for Python 3.2 and 3.3, and added support for Python 3.5.

Top link above

@tomchristie
Copy link
Member

Yup

py32: python3.2
py33: python3.3
py34: python3.4
py35: python3.5
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Travis doesn't yet have Python 3.5 available. See build here:

$ tox -e $TOX_ENV
GLOB sdist-make: /home/travis/build/tomchristie/django-rest-framework/setup.py
py35-djangomaster create: /home/travis/build/tomchristie/django-rest-framework/.tox/py35-djangomaster
ERROR: InterpreterNotFound: python3.5

It's in allowed_failures but I will investigate.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carltongibson IMHO it's good enough as it stands. We might reconsider that once 1.9 is out.

@tomchristie
Copy link
Member

  1. Lets make the PR against the 3.3 branch.
  2. Updates also against docs/README.
  3. We could consider still supporting 1.6 - just because it isn't getting security releases anymore doesn't necessarily mean third party packages need to stop supporting it. Unsure.

@carltongibson
Copy link
Collaborator Author

OK. I'll redo the PR against 3.3 — and add the README/doc notes.

I don't mind which of the changes we want here. My personal view is to follow Django's supported versions, unless some commercial body wants to fund extra. But I'm not religious about that.

@carltongibson
Copy link
Collaborator Author

Re the Django 1.5/1.6 thing, I just had this conversation on django-appconf. It's more or less what I think:

...for me it's a scope thing. We have limited time to support the project, and, despite the fact that commercial bodies use/rely on the project, nobody is going to jump in with an offer to support development — so we do need to draw the line tightly. IMO. Discuss. :-)

@tomchristie
Copy link
Member

Probably stuff to remove in compat too.

I'd say supporting a fixed number of Django versions would be reasonable. (Either 3 or 4)

@carltongibson
Copy link
Collaborator Author

I'll reopen this against 3.3.

@carltongibson carltongibson deleted the django-19-python-versions branch August 29, 2017 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants