Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review supported Django Versions and Compat #3408

Closed
2 tasks
carltongibson opened this issue Sep 16, 2015 · 17 comments
Closed
2 tasks

Review supported Django Versions and Compat #3408

carltongibson opened this issue Sep 16, 2015 · 17 comments
Labels

Comments

@carltongibson
Copy link
Collaborator

Following the discussion in #3405

  • Decide what versions of Django are we going to support.
  • Review code in compat.py in accordance with that.
@carltongibson
Copy link
Collaborator Author

@tomchristie @xordoquy — If you make a decision here I'm happy to tidy up the compat module.

@tomchristie
Copy link
Member

Well we'll certainly want to drop 1.5 for 3.3 so I'd suggest that as a commit.

@tomchristie
Copy link
Member

1.6 also possible, but treat as a seperate commit if so.

@xordoquy
Copy link
Collaborator

Seconded. This will allow us to drop support for Python 2.6 as well.

@tomchristie
Copy link
Member

I think dropping 2.6 for 3.3 should be unambiguous as well, right?

@xordoquy
Copy link
Collaborator

We'll make it clear but once Django 1.5 / 1.6 will be removed from the supported version we won't have any Django compatible with Python 2.6.

@carltongibson
Copy link
Collaborator Author

So drop 1.6?

@tomchristie
Copy link
Member

I think we should drop python 2.6.
I don't think that should have any influence on which Django versions we support (tho dropping 1.6 could be valid in its own right)

@carltongibson
Copy link
Collaborator Author

OK, I'll make the PR assuming dropping both — we can always change our minds before merging.

(Anyone on Django 1.6 could use v3.2.x — which would still work for them — they can't be that bothered about what versions they're on anyhow...)

@tomchristie
Copy link
Member

py1.7+ dj1.6+ would seem reasonable to me at this point, but deps on how much of compat we can remove if we also drop dj1.6

@xordoquy
Copy link
Collaborator

I'd rather we align the supported Python version to what Django does but won't oppose it.

@carltongibson
Copy link
Collaborator Author

I'd rather we align the supported Python version to what Django does but won't oppose it.

I agree here. If we keep Django 1.6, we should keep Python 2.6. (Opinion)

I'll do it in stages, keeping 2.6/1.6 to begin. Then I'll have a look at what we can drop if we get rid of it and we can decide then.

@xordoquy
Copy link
Collaborator

Let me know if / how I can help here.

@carltongibson
Copy link
Collaborator Author

OK. Will do! 👍

@carltongibson
Copy link
Collaborator Author

@xordoquy Let me know if you want #3404 — happy to finish it if so. (Equally happy to let it go if you don't think it's a helper)

@xordoquy
Copy link
Collaborator

Got some time this evening, will do.

@carltongibson
Copy link
Collaborator Author

I'm going to close this. Whatever we decide on #3429 settles it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants