Change default umask from 777 to 022
#22589
Conversation
|
Thanks @sbc100 for taking a look at the PR 🙇 ! It's my first attempt to add unit tests to the repository, so bear with me for any mistakes 😅 . |
Thanks for your contribution! Much appreciated. |
|
Btw, I picked the value |
test/stat/test_umask.c
Outdated
| } | ||
|
|
||
| int main() { | ||
| signal(SIGABRT, cleanup); |
There was a problem hiding this comment.
Can you remove this line, along with the cleanup function?
There was a problem hiding this comment.
I've addressed this in 9619d38.
test/stat/test_umask.c
Outdated
|
|
||
| int main() { | ||
| signal(SIGABRT, cleanup); | ||
| test(); |
There was a problem hiding this comment.
Also I guess you might as well inline the test into main since that is all it contains now.
There was a problem hiding this comment.
Yep, good point. I've applied this in 9619d38.
test/test_other.py
Outdated
| @also_with_wasmfs | ||
| def test_umask(self): | ||
| self.set_setting("FORCE_FILESYSTEM") | ||
| self.do_runf('stat/test_umask.c', 'success') |
There was a problem hiding this comment.
Can you move this test into test/other? And then use do_other_test to run it? You can run it with --rebase to generate the expected output.
There was a problem hiding this comment.
Oh, sorry, I forgot to relocate the file after b0d7dcf.
There was a problem hiding this comment.
I've addressed this in 9619d38.
test/stat/test_umask.c
Outdated
| // Get the default umask | ||
| mode_t default_umask = get_umask(); | ||
| printf("default umask: %o\n", default_umask); | ||
| assert(default_umask == 027); |
There was a problem hiding this comment.
I think making the default 022 makes sense yes.
There was a problem hiding this comment.
I agree, I'll update it.
There was a problem hiding this comment.
I've updated this in 2891de1.
fluiddot
changed the title
umask from 777 to 027umask from 777 to 022
| @@ -28,7 +28,7 @@ static int g_pid = 42; | |||
| static int g_pgid = 42; | |||
| static int g_ppid = 1; | |||
| static int g_sid = 42; | |||
| static mode_t g_umask = S_IRWXU | S_IRWXG | S_IRWXO; | |||
| static mode_t g_umask = S_IWGRP | S_IWOTH; | |||
There was a problem hiding this comment.
For reference, here are the definitions of values used here:
emscripten/system/lib/libc/musl/include/sys/stat.h
Lines 60 to 74 in 8eb432e
|
Thanks @sbc100 for reviewing and approving the PR 🙇 ! |
Addresses #17269.
This PR follows the approach made in #17270 but sets default
umaskto a more permissive value (022). Additionally, it includes a unit test to coverumaskfunctionality.