-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override default umask
in PHP
#555
Conversation
umask
in PHP more permissiveumask
in PHP
Heads up that this solution won't fix 8818-gh-Automattic/dotcom-forge. More info in https://github.com/Automattic/dotcom-forge/issues/8818#issuecomment-2368833340. |
Following this comment, I'm going to implement a different approach to override the |
This approach replaces the one using a plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fixes the issue for me. I was able to fix the broken Sage site:
rm -rf wp-content/cache
cd wp-content/themes/sage-vite
yarn install && composer install && yarn build
Related to 8816-gh-Automattic/dotcom-forge.
Proposed Changes
In the meantime, we'll create an internal plugin that will override the defaultumask
value. Note that this plugin is located in a special folder managed by Playground for platform-level-specific plugins.umask
value by pretending a PHP file using theauto_prepend_file
PHP directive.Testing Instructions
Create files with test file
npm start
.test.php
, at the root level on the site, with the following content:http://localhost:<PORT>/test.php
.umask
value shown on the page is0022
.rwxr-xr-x
(Full access to owner, and only READ and EXECUTE permissions to group and others).Addresses #269
npm start
.cd wp-content/themes
.git clone https://github.com/DevArge/sage-vite.git
.cd sage-vite
.yarn install && composer install && yarn build
.Pre-merge Checklist