Factor out compiler commands in test_other.py #11285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for various future improvements, but more more immediately allows for #11280 to land (because I want to be able to add `-Wno-fastcomp` across the board.
kripken
approved these changes
May 29, 2020
| @@ -157,13 +157,21 @@ def parse_wasm(filename): | |||
|
|
|||
|
|
|||
| class other(RunnerCore): | |||
| # Define the compiler command in a single location. This allows is to add flags, etc, that | |||
| # Define the compiler command in a single location. This allows is to add flags, etc, that | ||
| # effect all tests. | ||
| # TODO(sbc): In future integrate with RunnerCore emcc_args and settings system. | ||
| # TODO(sbc): Use emcc (the sheell script) and emcc.bat rather than assuming emcc.py is a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for various future improvements, but more more
immediately allows for #11280 to land (because I want to be able
to add
-Wno-fastcompacross the board).