Add warning about fastcomp deprecation #11280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschuff
reviewed
May 28, 2020
kripken
approved these changes
May 28, 2020
|
I think i'm happy with message as is now.. No need to embed the entire plan in the error string. " But this did make be realize I don't think we have bug for removing fastcomp :) |
dschuff
approved these changes
May 28, 2020
sbc100
added a commit
that referenced
this pull request
May 29, 2020
This allows for various future improvements, but more more immediately allows for #11280 to land (because I want to be able to add `-Wno-fastcomp` across the board.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be disabled, like all warnings, with
-Wno-fastcomp