Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Entity Model Features: Player Animations #313

Open
HB-Stratos opened this issue May 17, 2024 · 8 comments
Open

Add Support for Entity Model Features: Player Animations #313

HB-Stratos opened this issue May 17, 2024 · 8 comments

Comments

@HB-Stratos
Copy link

Entity Model Features adds compatibility for Optifine's Custom Entity Models, and extends the system so resource packs can animate the player too. This requires a custom renderer for the player model, which currently doesn't work with the TrinketRenderer.translateTo... functions. The result is that cosmetics rendered by custom renderers, like the create mod goggles (renderer code here), do not move correctly with the player as they assume vanilla player model movement.

Jdk-17.0.8.101-hotspot.2024.05.17.-.09.40.49.03.mp4

Having searched around a bit I believe the best way to fix this may be to extend the TrinketRenderer.translateTo... functions to detect whether EMF is currently present and the custom player model feature is in use, and if so, it should provide rotation matrices that follow the player model rendered by EMF.

@HB-Stratos HB-Stratos changed the title Add Support for Entity Model Features Add Support for Entity Model Features: Player Animations May 17, 2024
@noawx
Copy link
Contributor

noawx commented May 20, 2024

Same problem. I think all mods that make the player have extra animations cause this issue, because it happened with Immersive Melodies and Better Combat

Unless those two use EMF too?

@HB-Stratos
Copy link
Author

as far as I know there currently is no solution. The feature needs to be implemented by either trinkets or EMF to get this fixed.

@secretchowc
Copy link

damn, and do you know if they listen to the community? because this was published in May and it is almost July.

@Angelic-Aether
Copy link

damn, and do you know if they listen to the community? because this was published in May and it is almost July.

And now it's August. Do any of y'all know if we'll be getting a fix any time soon?

@IjiyaKokujo
Copy link

same here

@viiizee
Copy link

viiizee commented Sep 7, 2024

How do you even go about adding a custom model for a trinket? I can't find any documentation anywhere on how to do this.. I just don't know the correct file pathing.. I'm not a programmer :(

@IranMine123
Copy link

IranMine123 commented Nov 19, 2024

same issue with Sophisticated Backpacks too.
but it not works when wearing backpack on chestplate too.

Fixed.

P3pp3rF1y/SophisticatedBackpacks#1223
Traben-0/Entity_Model_Features#289

Screen.Recording.2024-11-19.194811.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants