Add Plot::plot_hovered_indexes interaction (index, subindex)
#2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingun
reviewed
Jan 13, 2023
Co-authored-by: Mingun <[email protected]>
|
I refactored to have the information of the hovered item such as is_in_radius, hovered indexes, item name. |
|
Screenshot without hover point overlay support but with ability to block priority with allow_hover.
|
haricot
force-pushed
the
indexes_hovered
branch
from
f268bbb to
71f7964
Compare
|
after commit 71f7964 |
haricot
changed the title
Plot::plot_hovered_indexes interaction (index, subindex)Plot::plot_hovered_indexes interaction (index, subindex)
haricot
changed the title
Plot::plot_hovered_indexes interaction (index, subindex)Plot::plot_hovered_indexes interaction (index, subindex)
haricot
changed the title
Plot::plot_hovered_indexes interaction (index, subindex)Plot::plot_hovered_indexes interaction (index, subindex)
|
I'm thinking of closing this PR in favor of a future pull request which integrates in Plot::Item a function src_index(plot_type: usize, src_index: usize ) which allows to use src_index() to return the type and a position in the origin of the data. |
|
closed in favor #2628 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
describe : emilk/egui_plot#4
related : #1778
depends : #2558