Add Esbuild resolver #1650
Merged
Add Esbuild resolver #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
esbuild-resolver
branch
from
a2893bc to
8d0d9c2
Compare
mansona
force-pushed
the
esbuild-resolver
branch
2 times, most recently
from
45b00fc to
e140c79
Compare
mansona
force-pushed
the
esbuild-resolver
branch
from
e140c79 to
35d2329
Compare
mansona
force-pushed
the
esbuild-resolver
branch
2 times, most recently
from
a171ed8 to
745813d
Compare
mansona
force-pushed
the
esbuild-resolver
branch
from
745813d to
fe8318a
Compare
NullVoxPopuli
approved these changes
Nov 29, 2023
void-mAlex
approved these changes
Nov 29, 2023
This was referenced Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the required esbuild resolvers so that the vite dependency optimisation step can discover our dependencies correctly.
This depends on #1648This PR is now ready to go