Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esbuild resolver should delegate dependency optimization to Vite #1618

Closed
mansona opened this issue Oct 2, 2023 · 1 comment
Closed

esbuild resolver should delegate dependency optimization to Vite #1618

mansona opened this issue Oct 2, 2023 · 1 comment
Assignees
@lolmaus

Comments

@mansona
Copy link
Member

mansona commented Oct 2, 2023

PR: #1614

This PR is a demo of the exact problem mansona/ember-vite-app#1

Essentially @ember/debug is a "fake" package that is provided by Ember and we need to have esbuild (the thing that does vite dependency optimisation) understand the embroider resolver
@mansona mansona converted this from a draft issue Oct 2, 2023
@mansona mansona moved this from Awaiting Review to Blocked in Mainmatter Embroider Team Oct 10, 2023
@mansona
Copy link
Member Author

mansona commented Feb 1, 2024

This issue was written before we understood exactly why the Vite build was failing. We solved the problem a different way: #1650

@mansona mansona closed this as completed Feb 1, 2024
@github-project-automation github-project-automation bot moved this from Waiting to Done in Mainmatter Embroider Team Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lolmaus lolmaus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lolmaus @mansona