[BREAKING CLEANUP beta] Update tsconfig to target ES2021 #20439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of our target browsers and Node versions for Ember v5.0 support ES2021, so update our TS version accordingly.
Notes: 1. We cannot currently upgrade beyond `broccoli-rollup` v3. Most likely this is related to the changes in Rollup v2, which seem to handle the circular dependencies more accurately; the net is that we end up dropping modules from the compiled output, though, which is undesirable (to say the least!). 2. We removed our usage of these rollup plugins some time ago, but we failed to drop them from `package.json`.
Since `broccoli-typescript-compiler` v8, we get `typescript` directly ourselves, and `broccoli-typescript-compiler` uses it as a peer dep rather than supplying it itself. Remove our custom lookup for it.
chriskrycho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of our target browsers and Node versions for Ember v5.0 support ES2021, so update our TS version accordingly.