fix: account for multi-options-per-identifer possibility #8153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
added
🏷️ bug
backport to release
|
@runspired I'm stuck here, there is some issue with my merge, but I'm unable to find it. As far as I can tell I've backported the entire change, but tests are failing. Not sure how much value this has since 4.7 is now released anyway and a 4.6.1 release is nice to have, but probably not critical. If you have some time can you take a look and see if you can spot what I missed? |
|
likely we don't need this anymore as stable releases with the fix have gone out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #8113 to release