Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for multi-options-per-identifer possibility #8113

Merged
merged 12 commits into from
Aug 12, 2022

Conversation

runspired
Copy link
Contributor

resolves #8110

Note: haven't fixed multi-options yet for the coalescing case, only the individual finds case

@runspired runspired added 🎯 beta PR should be backported to beta 🎯 release PR should be backported to release 🏷️ bug This PR primarily fixes a reported issue labels Aug 9, 2022
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Asset Size Report for 4dce001

Modern Builds

✅ EmberData shrank by -429.0 B (-71.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData +167.2 KB -429.0 B (+35.05 KB -71.0 B compressed)
    @ember-data/store +42.97 KB -429.0 B (+9.01 KB -71.0 B compressed)
        @ember-data/store/-private +41.97 KB -429.0 B (+8.8 KB -71.0 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '167.20 KB' │
│ compressed │ '35.05 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '45.74 KB' │
│  compressed  │ '9.59 KB'  │
│ % Of Library │   '27.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 45.26 KB  | 9.49 KB    | 99.0          | 27.1
	@ember-data/model/index                           | 486.00 B  | 101.87 B   | 1.0           | 0.3

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '42.97 KB' │
│  compressed  │ '9.01 KB'  │
│ % Of Library │   '25.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 41.97 KB  | 8.80 KB    | 97.7          | 25.1
	@ember-data/store/index                           | 1022.00 B | 214.24 B   | 2.3           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '24.05 KB' │
│  compressed  │ '5.04 KB'  │
│ % Of Library │   '14.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 24.05 KB  | 5.04 KB    | 100.0         | 14.4

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.42 KB' │
│  compressed  │ '4.28 KB'  │
│ % Of Library │   '12.2'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.36 KB   | 1.54 KB    | 36.0          | 4.4
	@ember-data/serializer/-private                   | 5.60 KB   | 1.17 KB    | 27.4          | 3.3
	@ember-data/serializer/json-api                   | 3.79 KB   | 813.56 B   | 18.6          | 2.3
	@ember-data/serializer/rest                       | 2.87 KB   | 615.05 B   | 14.0          | 1.7
	@ember-data/serializer/index                      | 611.00 B  | 128.08 B   | 2.9           | 0.4
	@ember-data/serializer/transform                  | 215.00 B  | 45.07 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.93 KB' │
│  compressed  │ '3.34 KB'  │
│ % Of Library │   '9.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.88 KB   | 1.65 KB    | 49.5          | 4.7
	@ember-data/adapter/-private                      | 3.79 KB   | 812.52 B   | 23.8          | 2.3
	@ember-data/adapter/error                         | 1.82 KB   | 391.16 B   | 11.4          | 1.1
	@ember-data/adapter/index                         | 1.41 KB   | 303.12 B   | 8.9           | 0.8
	@ember-data/adapter/json-api                      | 1.03 KB   | 221.99 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.66 KB' │
│  compressed  │ '1.82 KB' │
│ % Of Library │   '5.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.11 KB   | 452.58 B   | 24.4          | 1.3
	ember-data/-private                               | 1.75 KB   | 375.02 B   | 20.2          | 1.0
	ember-data/adapters/errors                        | 1.19 KB   | 255.11 B   | 13.7          | 0.7
	ember-data/setup-container                        | 368.00 B  | 77.14 B    | 4.2           | 0.2
	ember-data/relationships                          | 318.00 B  | 66.66 B    | 3.6           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 57.43 B    | 3.1           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 52.61 B    | 2.8           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 51.35 B    | 2.8           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 50.93 B    | 2.7           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 50.93 B    | 2.7           | 0.1
	ember-data/transform                              | 241.00 B  | 50.52 B    | 2.7           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 49.68 B    | 2.7           | 0.1
	ember-data/serializer                             | 232.00 B  | 48.63 B    | 2.6           | 0.1
	ember-data/adapter                                | 226.00 B  | 47.37 B    | 2.5           | 0.1
	ember-data/model                                  | 222.00 B  | 46.53 B    | 2.5           | 0.1
	ember-data/store                                  | 222.00 B  | 46.53 B    | 2.5           | 0.1
	ember-data/attr                                   | 218.00 B  | 45.69 B    | 2.5           | 0.1
	ember-data/version                                | 161.00 B  | 33.75 B    | 1.8           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.67 KB' │
│  compressed  │ '1.40 KB' │
│ % Of Library │   '4.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.96 KB   | 636.01 B   | 44.4          | 1.8
	ember-inflector/lib/system/inflections            | 1.59 KB   | 341.06 B   | 23.8          | 1.0
	ember-inflector/lib/system                        | 471.00 B  | 98.73 B    | 6.9           | 0.3
	ember-inflector/index                             | 379.00 B  | 79.44 B    | 5.6           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 77.35 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 69.59 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 66.66 B    | 4.7           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 62.04 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.77 KB'  │
│  compressed  │ '593.87 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.27 KB   | 488.00 B   | 82.2          | 1.4
	@ember-data/debug/setup                           | 505.00 B  | 105.86 B   | 17.8          | 0.3

Modern Builds (No Rollup)

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬──────────┐
│  (index)   │  Values  │
├────────────┼──────────┤
│   bytes    │ '0.00 B' │
│ compressed │ '1.00 B' │
│  packages  │    0     │
│  modules   │    0     │
└────────────┴──────────┘

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Performance Report for 4dce001

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-30ms to 11ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-4ms to 13ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-17ms to 2ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-12ms to 3ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-39ms to 10ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-13ms to 17ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-21ms to 3ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-8ms to 5ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-19ms to 26ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-13ms to 16ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-8ms to 14ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-9ms to 7ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-29ms to 7ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-23ms to 10ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-5ms to 7ms]
✅ Phase [start-push-update-payload] => [end-push-update-payload]
phase estimated improvement -3ms [-6ms to -1ms] OR -2.39% [-4.43% to -0.53%]
✅ Phase [end-push-update-payload] => [Test End]
phase estimated improvement -1ms [-2ms to 0ms] OR -2.28% [-4.71% to -0.14%]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-5ms to 38ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-4ms to 29ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-8ms to 12ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-1ms to 2ms]

@runspired runspired force-pushed the runspired/fix-fetch-options branch from df39ecf to 9367d0f Compare August 11, 2022 18:47
@runspired runspired force-pushed the runspired/fix-fetch-options branch from 340ff94 to 48878c4 Compare August 12, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 beta PR should be backported to beta 🎯 release PR should be backported to release 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.6.1 Error: [object Object] was already assigned a value for fetch-options
1 participant