-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX release] Add blueprints to ember-data package. #6241
Conversation
The failures here seem related to my changes, will have to dig in and figure out whats going on... |
In 3.11 ember-data migrated its blueprints to belong to the specific packages that they operate on. Unfortunately, ember-cli (at least as of 3.12) only supports discovering blueprints from addons that are direct dependencies or devDependencies of the project. This adds re-exports for each of the blueprints from the top level `ember-data` package in order to make `ember g model` (and friends) work properly when the project depends on `ember-data` and not the individual `@ember-data/*` packages themselves.
262724b
to
c8d8c04
Compare
I tested this locally, seems to work |
Created an issue since we are skipping the CI tests to unblock: #6263 |
This still seem to be broken in It's also broken in Have used |
@jelhan likely you aren't picking up
|
hrm, actually while the generators run successfully no files appear 🤔 |
This should fix it: #6274 |
In 3.11 ember-data migrated its blueprints to belong to the specific packages that they operate on. Unfortunately, ember-cli (at least as of 3.12) only supports discovering blueprints from addons that are direct dependencies or devDependencies of the project.
This adds re-exports for each of the blueprints from the top level
ember-data
package in order to makeember g model
(and friends) work properly when the project depends onember-data
and not the individual@ember-data/*
packages themselves.