Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI unskip node:test for blueprints #6263

Closed
runspired opened this issue Jul 19, 2019 · 0 comments · Fixed by #6274
Closed

CI unskip node:test for blueprints #6263

runspired opened this issue Jul 19, 2019 · 0 comments · Fixed by #6274
Labels
🏷️ bug This PR primarily fixes a reported issue 🏷️ test This PR primarily adds tests for a feature

Comments

@runspired
Copy link
Contributor

We skipped them here: #6241

TL;DR the blueprint test helper does not have a way for us to configure the app environment and so both ember-data and the specific package (such as @ember-data/model) will be top-level dependencies. The blueprint re-export from ember-data is winning out and does not work in this configuration environment. We need to improve both ember-cli-bluepriint-test-helpers and ember-cli to enable the environment to be configured to either ensure the correct blueprint is used or remove ember-data from it.

cc @Turbo87 @rwjblue for CLI needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bug This PR primarily fixes a reported issue 🏷️ test This PR primarily adds tests for a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant