[BUGFIX beta] Overhaul attr/relationships imports in model blueprint #4331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a model is generated via
ember generate model
without attributesand relationships, then it is not immediately clear from the generated
blueprint, on how to add attributes and relationships via importing
stuff from the modules.
This change adds the imports as comments, so uncommenting allows to
quickly add the imports without writing the import statement. So the
command
ember genrate model foo
now creates this file:This has been raised in the
#-ember-data
slack channel, where it was confusing on how to add attributes and relationships, since there is noimport DS from "ember-data"
in the generated file anymore, and it is not immediately clear whereattr
,belongsTo
andhasMany
are imported from.