Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

Update Models section to use the new import syntax #1391

Closed
acorncom opened this issue Apr 22, 2016 · 7 comments
Closed

Update Models section to use the new import syntax #1391

acorncom opened this issue Apr 22, 2016 · 7 comments

Comments

@acorncom
Copy link
Contributor

In the new Ember Data blueprints, apparently things have changed to this:

import Model from 'ember-data/model';
import attr from 'ember-data/attr';

export default Model.extend({
    title: attr(),
    owner: attr(),

Whereas we still have DS.Model and DS.attr mentioned here: https://guides.emberjs.com/v2.5.0/models/defining-models/

@acorncom
Copy link
Contributor Author

@locks how do we get folks to let us know about this ahead of time? seems like something we missed on the 2.5 update?

@locks
Copy link
Contributor

locks commented Apr 22, 2016

@acorncom we need to monitor every single thing ¯\_(ツ)_/¯

@toddjordan
Copy link
Contributor

@acorncom should be like core has been doing - no docs no ship

@pangratz
Copy link
Member

Sorry, I should have addressed this once emberjs/data#4331 got merged 😔 . I will create a PR to update this in the guides this weekend.

Also, I will try to remember this for future things, so this doesn't become an issue anymore!

Thanks btw for the hard work on keeping the guides up to date! 🚀

@pangratz
Copy link
Member

Oh, looks like good guy @Gaurav0 already took care of this in #1375 ❤️

@locks
Copy link
Contributor

locks commented Apr 22, 2016

We might try bridge the gap with some tooling, but it's such an unspecific space that I worry about adding even more overhead.
If everything was implemented in TS, maybe we could check the types :trollface:
@pangratz ping us on Slack if you have any ideas.

@locks locks closed this as completed Apr 22, 2016
@acorncom
Copy link
Contributor Author

Sorry, hadn't checked master before posting ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants