deprecate support for DS.FixtureAdapter #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should close #2804 |
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| ### Master | |||
|
|
|||
| - Removed support for DS.FixtureAdapter. You can use it as an addon, or | |||
| build it using Ember Shrinkwrap. https://github.com/emberjs/ember-data-fixture-adapter/tree/master | |||
|
The |
fivetanley
force-pushed
the
remove-fixture-adapter
branch
2 times, most recently
from
3781a10 to
7a57eb6
Compare
| writable: false, | ||
| configurable: false, | ||
| value: null, | ||
| set: function(){ |
There was a problem hiding this comment.
Shouldn't this be the getter?
fivetanley
force-pushed
the
remove-fixture-adapter
branch
from
7a57eb6 to
57568ee
Compare
|
It kinda feels like there should be a deprecating release, or at least a DS.FixtureAdapter in core that throws a helpful error for users if they try to use it. |
|
Yes, if you look at the code it is there ;P https://github.com/emberjs/data/pull/3091/files#diff-7a9b7714c153305dd4a831e18d6485bbR136 |
fivetanley
force-pushed
the
remove-fixture-adapter
branch
2 times, most recently
from
b9cdad1 to
d834ea7
Compare
fivetanley
changed the title
fivetanley
force-pushed
the
remove-fixture-adapter
branch
from
d834ea7 to
c4607fa
Compare
The FixtureAdapter has needed work for a long time, and without a champion to maintain it, it is being moved out of core and into an addon. You can see the addon at https://github.com/emberjs/ember-data-fixture-adapter/tree/master. We recommend you use an AJAX stubbing solution such as Pretender: https://github.com/trek/pretender
fivetanley
force-pushed
the
remove-fixture-adapter
branch
from
c4607fa to
6ffa70c
Compare
fivetanley
added a commit
that referenced
this pull request
May 23, 2015
deprecate support for DS.FixtureAdapter
|
👍 is there an issues to update the guides already? |
This was referenced May 24, 2015
|
@joostdevries I don't think so, can @fivetanley confirm? @joostdevries Do you want to tackle that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FixtureAdapter has needed work for a long time, and without a
champion to maintain it, it is being moved out of core and into an
addon. You can see the addon at
https://github.com/emberjs/ember-data-fixture-adapter/tree/master.
We recommend you use an AJAX stubbing solution such as Pretender:
https://github.com/trek/pretender