FixtureAdapter.find() returns undefined when model not found

[orospakr]

Rather than throwing the appropriate model not found exception in the event of a request for a non-extant id, FixtureAdapter returns undefined which breaks an assertion in Store._find(), which is unhandleable and breaks the whole app.

This is with ember-data 1.0.0beta7. I'm using EAK if that matters.

Assertion Failed: You made a request for a mymodel with id fixture-78, but the adapter's response did not have any data

[igorT]

Seems related to #1767

[wecc]

It seems that there's no code path in FixtureAdapter.find() that will reject the find and because of that the "normal" not found behavior is never reached.

• https://github.com/emberjs/data/blob/master/packages/ember-data/lib/adapters/fixture_adapter.js#L138
• https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/store.js#L1754-L1765

[xcambar]

I have a tailored FixtureAdapter which calls an overridable fixtureNotFound method (see https://github.com/xcambar/data/blob/extendable_fixture_adapter/packages/ember-data/lib/adapters/fixture_adapter.js#L176-L199)

Would you be interested in a minimal PR implementing this, with fixtureNotFound defaulting to a rejection?

[wecc]

I think it would suffice to return Ember.RSVP.reject() to get the same behavior as with the RESTAdapter?

[wecc]

The FixtureAdapter has been deprecated (#3091) and is no longer included in Ember Data by default.

The code for FixtureAdapter has been moved to emberjs/ember-data-fixture-adapter, please re-open in that repo if this is still an issue.