Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0 blockers for Tomhuda to review: #3298

Closed
10 tasks done
igorT opened this issue Jun 11, 2015 · 4 comments
Closed
10 tasks done

1.0 blockers for Tomhuda to review: #3298

igorT opened this issue Jun 11, 2015 · 4 comments

Comments

@igorT
Copy link
Member

igorT commented Jun 11, 2015

Simple: should take 1-8 minutes of discussion

Medium Complexity: should not take more than 5-15 minutes

@igorT
Copy link
Member Author

igorT commented Jun 11, 2015

@wycats @tomdale please advise

@igorT igorT mentioned this issue Jun 11, 2015
28 tasks
@wycats
Copy link
Member

wycats commented Jun 11, 2015

Consider renaming rollback to rollbackAttributes

Works for me.

Consider changing isDirty flag to something like areAttributesDirty

Works for me.

(do not break the old names, even for 2.0, though)

Considering moving store.filter into an addon

Good idea. It feels risky to commit to the API right now.

Consider renaming the serializer attrs hash
Consider renaming DS.Snapshot

What are the best options?

Confirm that this is the right thing to do: #3220

Can confirm. @tomdale should check me.

@runspired
Copy link
Contributor

@bmac has edited this comment by @runspired and moved it to #3274 (comment) in order to reduce some of the noise in this issue.

@tomdale
Copy link
Member

tomdale commented Jun 12, 2015

Confirm that this is the right thing to do: #3220
Can confirm. @tomdale should check me.

Confirm

@igorT igorT closed this as completed Jun 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants