Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store.query/queryRecord url behavior #3297

Closed
igorT opened this issue Jun 11, 2015 · 2 comments
Closed

Store.query/queryRecord url behavior #3297

igorT opened this issue Jun 11, 2015 · 2 comments

Comments

@igorT
Copy link
Member

igorT commented Jun 11, 2015

Currently if you do

store.queryRecord('user', {options})

those options are passed to the adapter, and inserted as query params. However a supper common use case is to want to trigger a request to

/users/current

However we have no semantic way of differentiating between query params and url options when they are passed in to the adapter. Should we add namespacing to the options object passed in to the query?
We could do the same, with adapterOptions, pagination etc. However, currently all the other adapter methods take a snapshot(remember discussion at https://hackpad.com/RecordArray-Snapshot-JO55bGRbwsn), and will look up the adapterOptions from the snapshot. Should these as well? It is not clear to me that they should as we will never have local data for a query. If they are not

@thaume
Copy link

thaume commented Jun 18, 2015

@igorT how can I help you with this issue ?

@fivetanley
Copy link
Member

We ended up using adapterOptions to namespace options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants