Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider refactoring the attrs hash for 1.0 #3186

Closed
igorT opened this issue Jun 3, 2015 · 2 comments
Closed

Consider refactoring the attrs hash for 1.0 #3186

igorT opened this issue Jun 3, 2015 · 2 comments

Comments

@igorT
Copy link
Member

igorT commented Jun 3, 2015

Serializers are currently customized using the attrs hash
For example: http://emberjs.com/api/data/classes/DS.RESTSerializer.html#property_attr
However the attrs hash grew out organically and applies to both relationships and attributes. The attrs name can be confusing, should we change it to options or smth?

@bmac
Copy link
Member

bmac commented Jun 4, 2015

Is this the attrs hash on the serializer?

@igorT
Copy link
Member Author

igorT commented Jun 4, 2015

Yes, it's weird its called attrs yet works for both attributes and relationships

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants