<@argument> Parsing error: Cannot read properties of null (reading 'index')
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limber:lint:js:fix: 0:0 error Parsing error: Cannot read properties of null (reading 'index')
|
|
This was referenced Dec 29, 2023
patricklx
reviewed
Dec 29, 2023
src/parser/transforms.js
Outdated
| @@ -268,7 +268,7 @@ module.exports.preprocessGlimmerTemplates = function preprocessGlimmerTemplates( | |||
| let codeSlice = code.slice(...n.range); | |||
| for (const part of n.tag.split('.')) { | |||
| let pattern = `\\b${part}\\b`; | |||
| if (part.startsWith(':')) { | |||
| if (part.startsWith(':') || part.startsWith('@')) { | |||
There was a problem hiding this comment.
I should probably extend this to any special character?
A tag could also be _Foo
There was a problem hiding this comment.
Or just use indexOf, that should work...
There was a problem hiding this comment.
Difference is _Foo could be defined locally
patricklx
force-pushed
the
argument-components
branch
from
b405f57
to
e1314df
Compare
patricklx
force-pushed
the
argument-components
branch
from
5c637bd
to
f45607b
Compare
NullVoxPopuli
commented
Dec 30, 2023
| let part = code.slice(...n.parent.range); | ||
| let start = n.parent.range[0]; | ||
| // for blocks {{x as |b|}} the block range does not contain the block params... | ||
| // for element tag it does <x as b /> |
There was a problem hiding this comment.
Suggested change
| // for element tag it does <x as b /> | |
| // for element tag it does <x as |b|> |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.