Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(markdown): re-enable markdown linting (see #284) #285

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

jayjayjpg
Copy link
Contributor

What it does

This reenables the markdown linting step in CI after merging #284

Related Issue(s)

Sources

@amyrlam
Copy link
Member

amyrlam commented Sep 23, 2019

lgtm. Are any of these rules no value added? https://github.com/ember-learn/ember-blog/blob/master/.markdownlint.json

Some of them I added such as no-trailing-punctuation, no-trailing-spaces, because it makes the diffs easier to review.

@jayjayjpg
Copy link
Contributor Author

@amyrlam I think the rules that we have so far are useful! I think that switching on the rules requires them to to be set to true in the config file, unless they're already set to true in the default config of the linter, but I haven't checked yet, how the default config actually looks like

I can take another look into it though or as you suggested, we can also brainstorm with the Times team, to see which rules make most sense for us

@amyrlam
Copy link
Member

amyrlam commented Sep 23, 2019

Oh yeah, sorry those are false haha 🙈

Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

down to merge it in, and if the rules are proving cumbersome, can iterate?

@jayjayjpg
Copy link
Contributor Author

down to merge it in, and if the rules are proving cumbersome, can iterate?

@amyrlam Yes, sounds good ✨

@jayjayjpg jayjayjpg merged commit cd5e66e into ember-learn:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants