Fixup Intro Separation for Ember Times Posts #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayjayjpg
changed the title
amyrlam
approved these changes
Sep 23, 2019
There was a problem hiding this comment.
👍 Looks good, let's add it to https://github.com/ember-learn/ember-blog/blob/master/source/embertimes-template.md too (could be done separate)
I can address the markdown-lint things separately. Maybe we should audit the rules as a group and just move forward with the ones that are important for a11y if it's too interruptive
|
cc @mixonic this will solve your concern with the weird cutoff on the blog, thanks @jessica-jordan / @chancancode |
jayjayjpg
added a commit
that referenced
this pull request
Sep 23, 2019
ci(markdown): re-enable markdown linting (see #284)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #274
What it does
Related Issue(s)
Sources