Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external ember-template-compiler #83

Merged
merged 3 commits into from
Jul 26, 2015

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Jul 26, 2015

Use external ember-template-compiler to allow for older versions of Ember.js

Fixes Issue #81

@rwjblue
Copy link
Member

rwjblue commented Jul 26, 2015

Submitted Gaurav0#1 to this branch, which should allow existing twiddle's to function properly.

@rwjblue
Copy link
Member

rwjblue commented Jul 26, 2015

We should add a test to confirm that various versions of Ember work (boot the app in the iframe), we can also add a variant that does not include ember-template-compiler in the twiddle.json to ensure existing twiddles work properly.

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Jul 26, 2015

@rwjblue Thanks. I'm generalizing your work a bit.

@Gaurav0 Gaurav0 changed the title [WIP] [BREAKING] Use external ember-template-compiler Use external ember-template-compiler Jul 26, 2015
@Gaurav0 Gaurav0 force-pushed the older_ember_template_compiler branch from 0621fb5 to 2b50ad7 Compare July 26, 2015 12:40
@Gaurav0 Gaurav0 force-pushed the older_ember_template_compiler branch from 2b50ad7 to 54d5343 Compare July 26, 2015 12:41
@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Jul 26, 2015

This is complete and ready for review.

rwjblue added a commit that referenced this pull request Jul 26, 2015
@rwjblue rwjblue merged commit aa79fe4 into ember-cli:master Jul 26, 2015
@rwjblue
Copy link
Member

rwjblue commented Jul 26, 2015

Thank you!

@Gaurav0 Gaurav0 deleted the older_ember_template_compiler branch March 21, 2016 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants