Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still cannot run older version of ember.js #81

Closed
Gaurav0 opened this issue Jul 26, 2015 · 3 comments
Closed

Still cannot run older version of ember.js #81

Gaurav0 opened this issue Jul 26, 2015 · 3 comments
Milestone

Comments

@Gaurav0
Copy link
Contributor

Gaurav0 commented Jul 26, 2015

See https://ember-twiddle-gaurav.herokuapp.com/e99546e0831d6d0251fc

Possibly loading / using the wrong version of ember-template-compiler?

@rwjblue
Copy link
Member

rwjblue commented Jul 26, 2015

We need to add the template compiler to twiddle.json. We can use the default one from https://cdnjs.cloudflare.com/ajax/libs/ember.js/1.13.5/ember-template-compiler.js

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Jul 26, 2015

@rwjblue Thanks for your help. The only issues now is that

  1. we no longer precompile templates
  2. This breaks existing twiddles

Breaking because existing twiddle.json's do not specify an external ember-template-compiler.

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Jul 26, 2015

Fixed by #83

@joostdevries joostdevries modified the milestone: v1.0 Jul 30, 2015
@Gaurav0 Gaurav0 closed this as completed Jul 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants