Fix navigation reload #297
Conversation
|
I've (temporarily) changed the CodeMirror dependency to the modified version so tests will pass on Travis. |
|
I changed |
| const enterKeyEvent = { keyCode: 3 }; | ||
|
|
||
| this.set('externalAction', (isUserChange) => { | ||
| assert.ok(isUserChange, 'contentChanged action was called'); |
There was a problem hiding this comment.
I think you need to change the test description to match the new behavior.
There was a problem hiding this comment.
I'm on mobile now so I could miss something, but what do you mean? The description is correct(imo) on the main test method above, and this assertion would say that it expected a true value (if it would fail). Did you mean to add that it expects a true value in this assertion?
There was a problem hiding this comment.
Instead of "contentChanged action was called", "contentChanged was called with isUserChange=true"
There was a problem hiding this comment.
Ah sure, I thought the title would be enough but I'll add it
|
This looks really good! Just need to fix up minor nits. |
| @@ -57,7 +57,7 @@ | |||
| "ember-moment": "4.2.1", | |||
| "ember-notify": "4.3.1", | |||
| "ember-responsive": "1.2.3", | |||
| "ivy-codemirror": "~1.2.0", | |||
| "ivy-codemirror": "piotrpalek/ivy-codemirror#pass-params", | |||
There was a problem hiding this comment.
It's ok if we can't, but I'd much prefer to make sure the upstream changes land before merging.
There was a problem hiding this comment.
Yes, please at least open a PR.
There was a problem hiding this comment.
Sure will do, it was just so you can see that the tests actually pass :)
There was a problem hiding this comment.
I've made a PR to CodeMirror
|
Changes landed upstream so I updated |
|
No need, and actually I'm not a fan of rewriting history. |
|
👍 |
|
👍 |
This fixes issue #290, but it depends on these changes to codemirror.