This repository has been archived by the owner on Mar 8, 2021. It is now read-only.
pass all event params to sendAction #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@omghax any thoughts on this? It would be awesome if it could be merged and released as a new version |
|
this LGTM, but I would recommend adding a quick test. |
|
LGTM. Not sure how you'd test this, aside from asserting that there were 3 arguments passed to |
omghax
added a commit
that referenced
this pull request
Dec 21, 2015
pass all event params to sendAction
|
Thanks for the PR :) I'll get a test in place shortly and then I'll release it as 1.3.0. |
omghax
added a commit
that referenced
this pull request
Dec 21, 2015
|
I was going to add a test (checking the amount of arguments) but seems like I'm too late here :) thx |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, this PR passes the CodeMirror event arguments to the
valueUpdatedaction. I think this can come in handy when building apps with this component. It is also needed to fix an issue in Ember Twiddle.