-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add travis deploy #101
Add travis deploy #101
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
#!/bin/bash | ||
# Deploy to staging/production on master/release merges (not PRs) | ||
|
||
set -e | ||
|
||
# Don't deploy on PRs | ||
if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then | ||
exit 0 | ||
fi | ||
|
||
if [ "$TRAVIS_BRANCH" == "master" ]; then | ||
# Deploy to staging on a merge to master | ||
ember deploy -e staging | ||
elif [ "$TRAVIS_TAG" != "false" ]; then | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the order might need to be swapped here (check for the tag first, then master). I can't recall off the top of my head what the branch is for tag builds... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nevermind, apparently There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is that a "+1" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, this is good, no need to tweak. |
||
# Deploy to production on a merge to release | ||
ember deploy -e production | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DO NOT COMMIT YOUR KEYS
CHANGE THEM NOW
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These types of keys are typically encrypted when commited to the
.travis.yml
, which may be the case here (they are not generally this long when unencrypted).@joostdevries can confirm (or fix 💃)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very 🔒. no worries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aka encrypted using travis public key