Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis deploy #101

Merged
merged 2 commits into from
Jul 30, 2015
Merged

Add travis deploy #101

merged 2 commits into from
Jul 30, 2015

Conversation

joostdevries
Copy link
Member

No description provided.

if [ "$TRAVIS_BRANCH" == "master" ]; then
# Deploy to staging on a merge to master
ember deploy -e staging
elif [ "$TRAVIS_TAG" != "false" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the order might need to be swapped here (check for the tag first, then master). I can't recall off the top of my head what the branch is for tag builds...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, apparently TRAVIS_BRANCH is not set on the build running for a tag.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that a "+1" :trollface:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is good, no need to tweak.

joostdevries pushed a commit that referenced this pull request Jul 30, 2015
@joostdevries joostdevries merged commit 7611b01 into master Jul 30, 2015
@joostdevries joostdevries deleted the add-travis-deploy branch July 30, 2015 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants