Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert broccoli-clean-css to v1.1.0 #55

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Revert broccoli-clean-css to v1.1.0 #55

merged 1 commit into from
Feb 27, 2019

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Feb 27, 2019

@Turbo87
Revert broccoli-clean-css to v1.1.0
5a155a3 
The update to v2.x was a breaking change, because we expose the `clean-css` options directly via `minifyCSS`
@Turbo87 Turbo87 added the bug label Feb 27, 2019
@Turbo87 Turbo87 requested a review from a team February 27, 2019 13:43
kellyselden
kellyselden approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@kellyselden kellyselden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discovered this recently too, temporarily fixed via yarn resolution.

@Turbo87 Turbo87 merged commit cde2809 into ember-cli:v3.x Feb 27, 2019
@Turbo87 Turbo87 deleted the revert-clean-css-upgrade branch February 27, 2019 13:51
@Turbo87 Turbo87 mentioned this pull request Feb 27, 2019
Closed
@gorner gorner mentioned this pull request Oct 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellyselden kellyselden kellyselden approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Turbo87 @kellyselden @mileslane