Update dependencies #27
Conversation
package.json
Outdated
| "broccoli-funnel": "^2.0.1", | ||
| "broccoli-merge-trees": "^3.0.1", | ||
| "debug": "^3.0.1", | ||
| "ember-cli-lodash-subset": "^2.0.1", |
There was a problem hiding this comment.
do we need ember-cli-lodash-subset at all?
There was a problem hiding this comment.
Yes, it's used in two other places (find and uniq)
There was a problem hiding this comment.
find is a native function now, isn't it? (at least on arrays?)
There was a problem hiding this comment.
Yes, I was thinking about replacing it, although uniq is still needed.
|
@twokul I've rewritten the two other use cases of |
| "ember-cli-lodash-subset": "^1.0.7", | ||
| "process-relative-require": "^1.0.0", | ||
| "silent-error": "^1.0.0" | ||
| "broccoli-clean-css": "^2.0.1", |
There was a problem hiding this comment.
it turns out that this was even more of a breaking change than I thought (https://github.com/jakubpawlowicz/clean-css#important-40-breaking-changes). we are exposing the clean-css options via minifyCSS.options and since the options have changed this in itself was a breaking change.
(see ember-cli/ember-cli#8447)
Once released will allow
ember-clito be installed without warning:warning ember-cli > ember-cli-preprocess-registry > broccoli-funnel > [email protected]: Please replace with usage of fs.existsSync