Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Node v12 and v14, add support for Node v16, v18 and v20 #777

Closed
wants to merge 3 commits into from
Closed

Drop support for Node v12 and v14, add support for Node v16, v18 and v20 #777

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3f73b2
Drop support for Node v12 and v14, add support for Node v16, v18 and v20
bertdeblock Aug 24, 2023
610b248
Increase yarn's network timeout on windows
bertdeblock Aug 24, 2023
ac34380
Remove `global` fallback
bertdeblock Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 16
- name: install dependencies
run: yarn install --frozen-lockfile
- name: lint:js
Expand All @@ -35,15 +35,15 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu, windows]
node-version: [12.x, 14.x]
node-version: [16, 18, 20]

steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: install dependencies
run: yarn install --ignore-engines --frozen-lockfile
run: yarn install --ignore-engines --frozen-lockfile --network-timeout 600000
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yarn installs on windows often fail, which is pretty time consuming.
This should hopefully improve that.

- name: node tests
run: yarn test:node
- name: ember test
Expand All @@ -59,7 +59,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 16
- name: install dependencies
run: yarn install --ignore-lockfile
- name: node tests
Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 16
- name: install dependencies
run: yarn install
- name: test
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

* Ember.js v3.8 or above
* Ember CLI v3.8 or above
* Node.js v12 or above
* Node.js v16 or above

## Tagged Template Usage / Migrating from `htmlbars-inline-precompile`

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
"webpack": "^5.58.2"
},
"engines": {
"node": "12.* || 14.* || >= 16"
"node": "16.* || 18.* || >= 20"
},
"publishConfig": {
"registry": "https://registry.npmjs.org"
Expand Down