Drop support for Node v12 and v14, add support for Node v16, v18 and v20 #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
commented
Aug 24, 2023
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - name: install dependencies | ||
| run: yarn install --ignore-engines --frozen-lockfile | ||
| run: yarn install --ignore-engines --frozen-lockfile --network-timeout 600000 |
There was a problem hiding this comment.
Yarn installs on windows often fail, which is pretty time consuming.
This should hopefully improve that.
void-mAlex
approved these changes
Aug 24, 2023
bertdeblock
commented
Aug 25, 2023
| // we must provide a `global` | ||
| // | ||
| // this is due to https://git.io/Jtb7s (Ember 3.27+) | ||
| if (!hasGlobalThis) { |
There was a problem hiding this comment.
Node >= v12 always has globalThis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.