[BUGFIX release] Update deprecation wording in init. #37
Conversation
The deprecation message has been rephrase to emphasize final users don't need to call `this._super`. Though the deprecation is still there, I hope rewording the message would prevent new users from panicking when receiving the deprecation warning.
| 'Please call this._super(), addon: `' + options.name + '`' | ||
| 'The addon `' + options.name + '` is overriding init without calling this._super. ' + | ||
| 'This behaviour is deprecated. ' + | ||
| 'This means that addon\'s writer needs to update it calling `this._super()` and release a new version. ' + |
There was a problem hiding this comment.
Both this and the other deprection should make the same suggestion RE: this._super.init && this._super.init.apply(this, arguments); (the message here just says this._super).
There was a problem hiding this comment.
I kept the original suggestion. I'll extract the deprecation message to be shown before the if then. Thank you!
|
Addressed both suggestions. Thank you! |
|
LGTM @stefanpenner - r? |
| 'This means that addon\'s author needs to update it calling `this._super.init && this._super.init.apply(this, arguments)` ' + | ||
| 'and release a new version. ' + | ||
| 'Do not worry, ember-cli is working normally.' | ||
| ); |
There was a problem hiding this comment.
why is this only one deprecation message now instead of the two separate ones before?
There was a problem hiding this comment.
The difference between them was how to solve it. Addressing this comment made them the same.
There was a problem hiding this comment.
This is too verbose (although I do appreciate the reasoning) so lets keep it short and instead link to shortened URL pointing to UPGRADE.MD or something in this repo.
The deprecation message has been rephrase to emphasize final users don't need to call
this._super.Though the deprecation is still there, I hope rewording the message would prevent new users from panicking when receiving the deprecation warning.
It is easier to update the message than to follow the other steps I suggested in the issue, so it seems like a feasible first step just in case ember-cli-release cannot be easily fixed.