Unable to run `ember init` after upgrading to 2.6.0 #5973

stevenwu · 2016-06-10T17:46:49Z

Unable to run ember init when upgrading from 2.5.1 to 2.6.0.

Output from ember version --verbose (project directory):

The addon `ember-cli-htmlbars` requires an Ember CLI version of 0.1.2 or above, but you are running null.
Error: The addon `ember-cli-htmlbars` requires an Ember CLI version of 0.1.2 or above, but you are running null.
    at Function.deprecatedAssertAbove [as assertAbove] (/Users/steve/work/noovis-ui/node_modules/ember-cli-version-checker/index.js:143:18)
    at CoreObject.module.exports.init (/Users/steve/work/noovis-ui/node_modules/ember-cli-htmlbars/ember-addon-main.js:13:13)
    at CoreObject.superWrapper [as init] (/Users/steve/work/noovis-ui/node_modules/core-object/lib/assign-properties.js:32:18)
    at CoreObject.Class (/Users/steve/work/noovis-ui/node_modules/core-object/core-object.js:33:38)
    at /Users/steve/work/noovis-ui/node_modules/ember-cli/lib/models/addons-factory.js:48:21
    at visit (/Users/steve/work/noovis-ui/node_modules/ember-cli/lib/utilities/DAG.js:23:3)
    at DAG.topsort (/Users/steve/work/noovis-ui/node_modules/ember-cli/lib/utilities/DAG.js:82:7)
    at CoreObject.extend.initializeAddons (/Users/steve/work/noovis-ui/node_modules/ember-cli/lib/models/addons-factory.js:44:11)
    at CoreObject.extend.initializeAddons (/Users/steve/work/noovis-ui/node_modules/ember-cli/lib/models/addon.js:220:38)
    at setupRegistryForEachAddon (/Users/steve/work/noovis-ui/node_modules/ember-cli-preprocess-registry/preprocessors.js:18:10)

Output from ember version --verbose (home directory):

ember-cli: 2.6.0
http_parser: 2.7.0
node: 6.2.1
v8: 5.0.71.52
uv: 1.9.1
zlib: 1.2.8
ares: 1.10.1-DEV
icu: 57.1
modules: 48
openssl: 1.0.2h
os: darwin x64

Tried with node 6.1.0, had same issue.

The text was updated successfully, but these errors were encountered:

stefanpenner · 2016-06-10T18:34:02Z

@stevenwu what version of ember-cli-htmlbars do you have?

Be sure to review https://github.com/ember-cli/ember-cli/blob/master/CONTRIBUTING.md#reporting-a-bug to provide actionable issues.

stefanpenner · 2016-06-10T18:58:14Z

i suspect you have a version of ember-cli-htmlbars pre 1.0.7, could you confirm?

stefanpenner · 2016-06-10T20:38:34Z

I've been attempting different configurations but have been so far unable to replicate. We will need more information to proceed...

nathanhammond · 2016-06-10T20:52:16Z

@stevenwu Can you paste in your package.json?

stevenwu · 2016-06-10T20:54:50Z

I tried to copy package.json and bower.json into a new 2.6.0 project earlier, but couldn't reproduce the erorr. Now I'm trying with a new 2.5.0 project upgrading to 2.6.0.

nathanhammond · 2016-06-10T20:58:18Z

@stevenwu My hope was that you could post it here for us to review your dependencies. Is that possible?

stevenwu · 2016-06-10T21:04:02Z

@nathanhammond I've reproduced the error https://github.com/stevenwu/ember-cli-issue-5973 .

stefanpenner · 2016-06-10T21:14:17Z

@stevenwu thanks, looking now.

stefanpenner · 2016-06-10T21:40:57Z

@nathanhammond / @stevenwu bumping ember-font-awesome to the latest fixed the issue. As it does the right thing.

Going to see if we can improve this somehow on our end, although I am unclear on that.

stefanpenner · 2016-06-10T21:52:17Z

I can't think of a solution beyond upgrading to the fixed ember-font-awesome.

The way I found it was via: CORE_OBJECT_WARN_DEPRECATED=1 ember s

which results in:

Deprecation: Overriding init without calling this._super is deprecated. Please call this._super.apply(this, arguments) ember-data
    at Function.Addon.lookup (/Users/stefanpenner/tmp/ember-cli-issue-5973/node_modules/ember-cli/lib/models/addon.js:879:27)
Deprecation: Overriding init without calling this._super is deprecated. Please call this._super.apply(this, arguments) ember-cli-dependency-checker
    at Function.Addon.lookup (/Users/stefanpenner/tmp/ember-cli-issue-5973/node_modules/ember-cli/lib/models/addon.js:879:27)
Deprecation: Overriding init without calling this._super is deprecated. Please call this._super.apply(this, arguments) ember-cli-jshint
    at Function.Addon.lookup (/Users/stefanpenner/tmp/ember-cli-issue-5973/node_modules/ember-cli/lib/models/addon.js:879:27)
Deprecation: Overriding init without calling this._super is deprecated. Please call this._super.apply(this, arguments) Ember CLI QUnit
    at Function.Addon.lookup (/Users/stefanpenner/tmp/ember-cli-issue-5973/node_modules/ember-cli/lib/models/addon.js:879:27)
Deprecation: Overriding init without calling this._super is deprecated. Please call this._super() ember-font-awesome
    at Function.Addon.lookup (/Users/stefanpenner/tmp/ember-cli-issue-5973/node_modules/ember-cli/lib/models/addon.js:879:27)

stefanpenner · 2016-06-10T21:52:24Z

@nathanhammond et. al. we could enable that warning by default?

PR to do that: ember-cli/core-object#33

crodriguez1a · 2016-06-13T22:33:00Z

@nathanhammond @stefanpenner I also ran into this issue with one of my add-ons. Adding the missing this._super call in the init method did seem to have fixed the issue. However, I didn't see the deprecation warning until (out of curiosity) I temporarily switched ember-cli-htmlbars from a dependency over to a dev dependency.

Then I was able to see:
DEPRECATION: Addon:ember-themed-syntaxis missing addon.project, this may be the result of an addon forgetting to invokesuperin its init.

Not sure if this helps at all. Thanks.

badazz91 · 2016-06-14T12:55:10Z

Had the same problem on my project.

Bumping ember-font-awesome to 2.1.1 did the trick.

stefanpenner · 2016-06-14T15:56:49Z

@crodriguez1a likely doing that forced NPM to download the latest core-object module, which contained that deprecation? or..

celicoo · 2016-06-16T22:38:51Z

Same issue here.

DEPRECATION: Overriding init without calling this._super is deprecated. Please call `this._super.init && this._super.init.apply(this, arguments);` ember-cli-dependency-checker
    at Function.Addon.lookup (/Users/marceloalves/DEV/Garimpo/Application/Application/node_modules/ember-cli/lib/models/addon.js:896:27)
DEPRECATION: Overriding init without calling this._super is deprecated. Please call `this._super.init && this._super.init.apply(this, arguments);` ember-cli-jshint
    at Function.Addon.lookup (/Users/marceloalves/DEV/Garimpo/Application/Application/node_modules/ember-cli/lib/models/addon.js:896:27)
DEPRECATION: Overriding init without calling this._super is deprecated. Please call `this._super.init && this._super.init.apply(this, arguments);` Ember CLI QUnit
    at Function.Addon.lookup (/Users/marceloalves/DEV/Garimpo/Application/Application/node_modules/ember-cli/lib/models/addon.js:896:27)
DEPRECATION: Overriding init without calling this._super is deprecated. Please call `this._super.init && this._super.init.apply(this, arguments);` release
    at /Users/marceloalves/DEV/Garimpo/Application/Application/node_modules/ember-cli/lib/models/project.js:404:38

stefanpenner · 2016-06-16T23:00:23Z

Deprecations are enabled by default, if you have issues please follow the deprecations instruction (either updating the addon in question, or fixing the addon in question).

This isn't an ember-cli issue, rather we are attempting to transition old add-ons in a helpful way.

Serabe · 2016-06-17T15:05:40Z

@stefanpenner is there any change to reconsider this until [email protected] or [email protected]? Currently a fresh installation of [email protected] shows three deprecation warnings all of them coming from files in ember-cli/lib/models

stefanpenner · 2016-06-17T15:46:46Z

@Serabe unfortunately do to how those add-on are wired up, that is the best stack trace we can give. For some add-ons we are able to give a better stack trace and we do, but for lots that information is quite tricky to get.

stefanpenner · 2016-06-17T15:49:12Z

the stack trace helps identify how the add-on was instantiated (either in ember-cli, or standalone), but the deprecation also clearly states which dependency needs fixed.

ember-cli-dependency-checker (pending release)
ember-cli-quint (already fixed)
release (I thought this was ember-cli-release, but doesn't appear to be the case?)

Serabe · 2016-06-19T11:21:54Z

@stefanpenner: I see the point on this comment. IMHO, a clean installation of ember-cli should not be raising any kind of deprecation. If ember-cli chooses to include an addon by default, I think this issue tracker would need to address those addons not raising any deprecation.

As an example, currently only ember-cli-release keep raising such deprecation, but ember-cli creates a package.json that fixes the version to 0.2.8 (it does not even allow to install 0.2.9 if it existed), while the fix has been released as a beta for 1.0.0. That means that the user needs to manually change package.json to a beta version of an addon as far the user knows is needed to run Ember CLI.

I would suggest releasing the fix in ember-cli-release as 0.2.9, changing package.json's ember-cli-release version to ^0.2.9 and releasing a 2.6.2 version with that fix. This would fix the issue without waiting for 2.7.0 and ease triaging issues, addressing questions on Slack, etc.

Thank you!

nathanhammond · 2016-06-19T17:09:24Z

@Serabe Your proposed solution isn't unreasonable. It's a time and energy thing. Please see my response on that thread.

rwjblue · 2016-06-19T18:55:55Z

In this case, we enabled the deprecations after 2.6 was already released out of "self defense" (there were a number of issues reported that the deprecation was intended to help with and addon authors had no clue they needed to take action).

I think in the future that we should try to land deprecations "on by default" during the beta period, so that addon authors at least have a chance to fix the underlying issues before final/stable releases.

I do not think there is much we can do at this point, other than what @Serabe suggested (RE: [email protected] and a [email protected]).

stefanpenner added the bug label Jun 10, 2016

stefanpenner modified the milestones: v2.6.0, v2.6.1 Jun 10, 2016

stefanpenner added Needs Submitter Response and removed bug labels Jun 10, 2016

stefanpenner removed this from the v2.6.1 milestone Jun 10, 2016

stefanpenner added Needs Team Discussion and removed Needs Submitter Response labels Jun 10, 2016

crodriguez1a mentioned this issue Jun 13, 2016

After installation: "The addon 'ember-cli-htmlbars' requires an Ember CLI version of 0.1.2 or above, but you are running null." crodriguez1a/ember-themed-syntax#3

Closed

stefanpenner closed this as completed Jun 16, 2016

This was referenced Jun 19, 2016

[BUGFIX release] Update deprecation wording in init. ember-cli/core-object#37

Closed

[BUGFIX release] Upgrade ember-cli-release version #6001

Merged

albertonavarro087 mentioned this issue Jun 20, 2016

Deprecation warning appear after upgrade from ember-cli 2.5.1 to 2.6.2 ciena-frost/ember-frost-core#127

Closed

WillCup mentioned this issue Jul 1, 2016

Hello steven stevenwu/ember-cli-issue-5973#1

Closed

drewda mentioned this issue May 4, 2017

error building from a fresh install of NPM and Bower packages transitland/feed-registry#390

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unable to run `ember init` after upgrading to 2.6.0 #5973

Unable to run `ember init` after upgrading to 2.6.0 #5973

stevenwu commented Jun 10, 2016 •

edited

Loading

stefanpenner commented Jun 10, 2016 •

edited

Loading

stefanpenner commented Jun 10, 2016

stefanpenner commented Jun 10, 2016

nathanhammond commented Jun 10, 2016

stevenwu commented Jun 10, 2016

nathanhammond commented Jun 10, 2016

stevenwu commented Jun 10, 2016

stefanpenner commented Jun 10, 2016

stefanpenner commented Jun 10, 2016 •

edited

Loading

stefanpenner commented Jun 10, 2016

stefanpenner commented Jun 10, 2016 •

edited

Loading

crodriguez1a commented Jun 13, 2016 •

edited

Loading

badazz91 commented Jun 14, 2016

stefanpenner commented Jun 14, 2016

celicoo commented Jun 16, 2016

stefanpenner commented Jun 16, 2016 •

edited

Loading

Serabe commented Jun 17, 2016

stefanpenner commented Jun 17, 2016 •

edited

Loading

stefanpenner commented Jun 17, 2016 •

edited

Loading

Serabe commented Jun 19, 2016

nathanhammond commented Jun 19, 2016

rwjblue commented Jun 19, 2016

Unable to run ember init after upgrading to 2.6.0 #5973

Unable to run ember init after upgrading to 2.6.0 #5973

Comments

stevenwu commented Jun 10, 2016 • edited Loading

stefanpenner commented Jun 10, 2016 • edited Loading

stefanpenner commented Jun 10, 2016

stefanpenner commented Jun 10, 2016

nathanhammond commented Jun 10, 2016

stevenwu commented Jun 10, 2016

nathanhammond commented Jun 10, 2016

stevenwu commented Jun 10, 2016

stefanpenner commented Jun 10, 2016

stefanpenner commented Jun 10, 2016 • edited Loading

stefanpenner commented Jun 10, 2016

stefanpenner commented Jun 10, 2016 • edited Loading

crodriguez1a commented Jun 13, 2016 • edited Loading

badazz91 commented Jun 14, 2016

stefanpenner commented Jun 14, 2016

celicoo commented Jun 16, 2016

stefanpenner commented Jun 16, 2016 • edited Loading

Serabe commented Jun 17, 2016

stefanpenner commented Jun 17, 2016 • edited Loading

stefanpenner commented Jun 17, 2016 • edited Loading

Serabe commented Jun 19, 2016

nathanhammond commented Jun 19, 2016

rwjblue commented Jun 19, 2016

Unable to run `ember init` after upgrading to 2.6.0 #5973

Unable to run `ember init` after upgrading to 2.6.0 #5973

stevenwu commented Jun 10, 2016 •

edited

Loading

stefanpenner commented Jun 10, 2016 •

edited

Loading

stefanpenner commented Jun 10, 2016 •

edited

Loading

stefanpenner commented Jun 10, 2016 •

edited

Loading

crodriguez1a commented Jun 13, 2016 •

edited

Loading

stefanpenner commented Jun 16, 2016 •

edited

Loading

stefanpenner commented Jun 17, 2016 •

edited

Loading

stefanpenner commented Jun 17, 2016 •

edited

Loading