Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support empty string as value of option #26

Merged
merged 3 commits into from
Dec 3, 2020
Merged

Support empty string as value of option #26

merged 3 commits into from
Dec 3, 2020

Conversation

javve
Copy link

@javve javve commented Nov 3, 2020

No description provided.

@javve javve marked this pull request as draft November 3, 2020 14:13
@javve javve marked this pull request as ready for review November 3, 2020 14:32
@javve javve mentioned this pull request Nov 3, 2020
Closed
hergaiety
hergaiety approved these changes Dec 3, 2020
View reviewed changes
Copy link

@hergaiety hergaiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for the PR, I'll get it merged it and fire up a patch release.

@hergaiety hergaiety merged commit 04c305e into ember-a11y:main Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hergaiety hergaiety hergaiety approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javve @hergaiety