Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow option with empty value #25

Closed
javve opened this issue Nov 3, 2020 · 3 comments
Closed

Allow option with empty value #25

javve opened this issue Nov 3, 2020 · 3 comments

Comments

@javve
Copy link

javve commented Nov 3, 2020

Thanks a lot for a nice lib. I'm currently in the process of switching from x-select to ember-select-light and I found something I would consider a bug.

It's not possible to have an option with a value that is just an empty string.

<SelectLight @value={{value}} @change={{action "myAction"}} @options={{selectOptions}} />
get selectOptions() {
  return [{
    label: 'Nothing',
    value: ''
  },{
    label: 'Option 1',
    value: '1'
  }]
}

At the moment this will result in this:
image
image

@javve
Copy link
Author

javve commented Nov 3, 2020

I created a PR if you're interested in allowing empty string as value ✌️ Check out: #26

@hergaiety
Copy link

@javve hey! I've updated my notification settings for this repository so that I'll notice these more quickly. Thanks for your patience on this.

Great issue logging and I highly appreciate the PR. It's been merged and a new patch release has been published to npm https://github.com/ember-a11y/ember-select-light/releases/tag/v2.0.4

@javve
Copy link
Author

javve commented Dec 3, 2020

Awesome @hergaiety! No worries, I've been using my fork until now with no issues ✌️
Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants