Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve session folder handling and added events for handling them #544

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Improve session folder handling and added events for handling them #544

merged 2 commits into from
Dec 20, 2018

Commits on Dec 20, 2018

  1. Improve session folder handling and added events for handling them 

    - added `lsp-auto-require-clients` to remove the need to require lsp-clients.
  When set to t(default) it will autorequire lsp-clients.

- `lsp` command ignores the clients which binary is not present.

- `lsp` no longer throws an error when there is no client installed

- `lsp` will ask which client to power on if there are multiple clients for a
  single mode present(also if their binary is available). This will happen each
  time you open a new file. In order to disable that you will have to remove the
  server that you do not want to run from `lsp-clients`. Later, when we solve
  emacs-lsp#405 we will be able to specify per project preferences like: ProjectA uses
  ccls, projectB uses clangd.

- If you want your client to run in parallel with other server you will have to
  specify `:add-on?` = t when registering the client.

- added 3 different message `lsp--info`, `lsp--warn` and `lsp--error`

- cleanup
- fixed support for tcp LANGUAGE server which apparently works only on Linux.

``` example registration
(lsp-register-client
 (make-lsp-client :new-connection (lsp-tcp-connection
                                   (lambda (port)
                                     `("php"
                                       ,(expand-file-name "~/.composer/vendor/felixfbecker/language-server/bin/php-language-server.php")
                                       ,(format "--tcp-server=localhost:%s" port)
                                       "--memory-limit=4095M")))
                  :major-modes '(php-mode)
                  :server-id 'php-ls))
```

- Implemented signature handling in single method.

Fixes emacs-lsp#214

- Changed eldoc message to display signature when it is present.

- Replaced the message calls with lsp-message which preserves the eldoc message.
At some point we may create separate buffer which will display the
    @yyoncho
    yyoncho committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    e54d2d8 View commit details
    Browse the repository at this point in the history

  2. Temporary comment flymake errors/warnings/info handling 

    - in some cases the lightner of flymake does not display the correct count
    @yyoncho
    yyoncho committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    7ef8a34 View commit details
    Browse the repository at this point in the history