Improve session folder handling and added events for handling them #544

yyoncho · 2018-12-14T20:13:45Z

Fixes #512

added lsp-auto-require-clients to remove the need to require lsp-clients.
When set to t(default) it will autorequire lsp-clients.
lsp command ignores the clients which binary is not present.
lsp no longer throws an error when there is no client installed
lsp will ask which client to power on if there are multiple clients for a
single mode present(also if their binary is available). This will happen each
time you open a new file. In order to disable that you will have to remove the
server that you do not want to run from lsp-clients. Later, when we solve
Can't configure lsp servers with file/directory local variables #405 we will be able to specify per project preferences like: ProjectA uses
ccls, projectB uses clangd.
If you want your client to run in parallel with other server you will have to
specify :add-on? = t when registering the client.
added 3 different message lsp--info, lsp--warn and lsp--error
cleanup
fixed support for tcp LANGUAGE server which apparently works only on Linux.

(lsp-register-client
 (make-lsp-client :new-connection (lsp-tcp-connection
                                   (lambda (port)
                                     `("php"
                                       ,(expand-file-name "~/.composer/vendor/felixfbecker/language-server/bin/php-language-server.php")
                                       ,(format "--tcp-server=localhost:%s" port)
                                       "--memory-limit=4095M")))
                  :major-modes '(php-mode)
                  :server-id 'php-ls))

MaskRay · 2018-12-15T06:33:16Z

I don't recommend advertising (add-hook 'prog-mode-hook 'lsp). It can be a supported configuration though. People don't use LSP for every prog-mode derivative.

lsp.el

yyoncho · 2018-12-15T07:17:46Z

I don't recommend advertising (add-hook 'prog-mode-hook 'lsp). It can be a supported configuration though. People don't use LSP for every prog-mode derivative.

After this PR when you open a file which does not have corresponding language server it will print the following message(no errors):

I will extend the readme section with:
"You could either attach lsp to prog-mode-hook which will try to start a language server for all programming languages and log a message when there is no configuration for the current major-mode or you could try to start lsp only for specific modes(+example code). "

What do you think?

yyoncho · 2018-12-15T07:25:59Z

More precisely:

"You could either attach lsp to prog-mode-hook which will try to start a language server for all programming languages and log a message when there is no configuration for the current major-mode and the corresponding language server is installed or you could try to start lsp only for specific modes(+example code). "

Fixes emacs-lsp#204 Requires: emacs-lsp/lsp-mode#544

MaskRay · 2018-12-17T07:41:21Z

README.org

+  Add the following line in your configuration file.
+  #+BEGIN_SRC emacs-lisp
+    (require 'lsp)
+    (add-hook 'prog-mode-hook 'lsp)


Even a warning language server ... is not available for some mode may be annoying for some people.

This option will be for initial configuration and targeted at beginners which are looking for zero configuration. Once you find the message irritating you can change it to work as you want(e. g. attach to the proper mode hook). Of course we may restructure the README based on the user feedback.

Beginners may not know what prog-mode-hook is and this suggestion does not provide any convenience.

People choose language servers very conservatively, as the status quo tools are not necessarily worse than LSP counterparts.

MaskRay · 2018-12-17T07:43:14Z

README.org

+    Add ~lsp~ server call to ~hack-local-variables-hook~ which runs right after the local variables are loaded.
+    #+BEGIN_SRC emacs-lisp
+      (add-hook 'hack-local-variables-hook
+                (lambda () (when (derived-mode-p 'prog-mode) (lsp))))


The prog-mode example should be specific as I have mentioned that prog-mode might not be a good example...

MaskRay · 2018-12-17T07:49:35Z

lsp.el

+(defun lsp-message (format &rest args)
+  "Wrapper over `message' which preserves the `eldoc-message'.
+FORMAT with ARGS are the original message formats."
+  (-let ((inhibit-message lsp-inhibit-message)


Does plain let work?

Yes, I will change it.

MaskRay · 2018-12-17T07:50:34Z

lsp.el

-  (DEPRECATED_send-sync nil :read-only t)
+  ;; ‘add-on?’ when set to t this will indicate that the server can be started as
+  ;; a additional to another server. In case there are several
+  (add-on? nil :read-only t)


The parameter name and its associate comments are still obscure to me.

Oh, the comment is not finished. When the server has add-on? = true this means that it will be started along the other servers for that mode. For example, spring-boot-language-server could run in parallel with jdt-ls. I am open for suggestions for better naming.

MaskRay · 2018-12-17T07:54:25Z

lsp.el

-  (put 'lsp-note 'flymake-category 'flymake-note)
-  (put 'lsp-warning 'flymake-category 'flymake-warning)
-  (put 'lsp-error 'flymake-category 'flymake-error)
+  ;; (put 'lsp-note 'flymake-category 'flymake-note)


https://github.com/emacs-mirror/emacs/blob/master/lisp/progmodes/flymake.el#L81

A different symbol lsp-note gives more flexibility.

Sure, but it does not work as I mentioned on Gitter - the Flymake modeline is displaying [0 0] with this change. I guess it is either a Flymake bug or Flymake misconfiguration but we need to figure it out before re-enabling.

It works here.

Ok, I will recompile latest emacs and I will test on emacs 26.1

MaskRay · 2018-12-17T07:56:04Z

lsp.el

@@ -1071,6 +1092,10 @@ If NO-WAIT is non-nil, don't synchronously wait for a response."
 (cl-defun lsp-request (method params &key no-wait)
  (lsp--send-request `(:jsonrpc "2.0" :method ,method :params ,params) no-wait))

+(defun lsp-request-async (method params callback &optional mode)


mode may be a good candidate for a keyword parameter.

Sure, will be updated.

MaskRay · 2018-12-17T07:59:38Z

lsp.el

+          lsp--eldoc-saved-hover-message nil)
+
+    (let (signature-response hover-response)
+      (if (lsp--capability "signatureHelpProvider")


By splitting signatureHelp and hover, the user can use lsp-eldoc-hook to do:

ignore signatureHelp

use signatureHelp only in evil-insert-state

other fancy stuff

That was why I added the hook.

signatureHelp may also be expensive to the server.

The problem with the current solution is that you should select one of signature or hover, but in the general case you want to see both which does not work without lsp-ui-doc. At this point you could disable whatever method you want by altering lsp-method-requirements which will be generic way to disable certain feature, I havent yet added this to the docs VSCode works in similar way. We could also add generic method toggle feature off to make it more user friendly.

But they can also provide their own callback, e.g.

(defun +my/hover-or-signature-help () (if (evil-insert-state-p) (lsp-signature-help) (lsp-hover)))

I will change the code to support this configuration.

yyoncho · 2018-12-19T16:36:03Z

@MaskRay Pushed version based on offline discussion, please take look whether I have missed something.

- added `lsp-auto-require-clients` to remove the need to require lsp-clients. When set to t(default) it will autorequire lsp-clients. - `lsp` command ignores the clients which binary is not present. - `lsp` no longer throws an error when there is no client installed - `lsp` will ask which client to power on if there are multiple clients for a single mode present(also if their binary is available). This will happen each time you open a new file. In order to disable that you will have to remove the server that you do not want to run from `lsp-clients`. Later, when we solve emacs-lsp#405 we will be able to specify per project preferences like: ProjectA uses ccls, projectB uses clangd. - If you want your client to run in parallel with other server you will have to specify `:add-on?` = t when registering the client. - added 3 different message `lsp--info`, `lsp--warn` and `lsp--error` - cleanup - fixed support for tcp LANGUAGE server which apparently works only on Linux. ``` example registration (lsp-register-client (make-lsp-client :new-connection (lsp-tcp-connection (lambda (port) `("php" ,(expand-file-name "~/.composer/vendor/felixfbecker/language-server/bin/php-language-server.php") ,(format "--tcp-server=localhost:%s" port) "--memory-limit=4095M"))) :major-modes '(php-mode) :server-id 'php-ls)) ``` - Implemented signature handling in single method. Fixes emacs-lsp#214 - Changed eldoc message to display signature when it is present. - Replaced the message calls with lsp-message which preserves the eldoc message. At some point we may create separate buffer which will display the

- in some cases the lightner of flymake does not display the correct count

…211) Fixes #204 Requires: emacs-lsp/lsp-mode#544

* use get_source_file * fix race condition in suggest specs Code lens request is handled asynchronously. If the file is closed and close notification handle_info executes before suggest_contracts handle_call the previous code added an entry to awaiting_contracts. That entry used URI of a closed file that would later lead to crash when handling analysis_ready Fixes elixir-lsp/vscode-elixir-ls#186

yyoncho mentioned this pull request Dec 14, 2018

[Enhancement] Automatic client detection #512

Closed

MaskRay reviewed Dec 15, 2018

View reviewed changes

lsp.el Outdated Show resolved Hide resolved

yyoncho force-pushed the wf branch from 7442998 to 3bcca79 Compare December 15, 2018 07:31

yyoncho mentioned this pull request Dec 15, 2018

Can't configure lsp servers with file/directory local variables #405

Closed

yyoncho force-pushed the wf branch 2 times, most recently from 6733d74 to 564afb8 Compare December 16, 2018 15:21

yyoncho added a commit to yyoncho/lsp-ui that referenced this pull request Dec 16, 2018

Fixes to document signature

982e11a

Fixes emacs-lsp#204 Requires: emacs-lsp/lsp-mode#544

yyoncho added a commit to yyoncho/lsp-ui that referenced this pull request Dec 16, 2018

Fixes to document signature

7bbdc31

Fixes emacs-lsp#204 Requires: emacs-lsp/lsp-mode#544

yyoncho mentioned this pull request Dec 16, 2018

LSP UI changes needed to make signature support work on lsp-ui side emacs-lsp/lsp-ui#211

Merged

yyoncho added a commit to yyoncho/lsp-ui that referenced this pull request Dec 16, 2018

LSP UI changes needed to make signature support work on lsp-ui side

b95f07b

Fixes emacs-lsp#204 Requires: emacs-lsp/lsp-mode#544

yyoncho mentioned this pull request Dec 16, 2018

Show method signature when writing the arguments of the method #214

Closed

yyoncho force-pushed the wf branch 2 times, most recently from 930f774 to 3c216c1 Compare December 17, 2018 06:26

yyoncho mentioned this pull request Dec 17, 2018

signatureHelp: support labelOffsetSupport #552

Merged

yyoncho force-pushed the wf branch from 3c216c1 to a3bb57f Compare December 17, 2018 06:57

MaskRay reviewed Dec 17, 2018

View reviewed changes

yyoncho mentioned this pull request Dec 17, 2018

adjust lsp--calculate-root for nest project when lsp-auto-guess-root … #553

Merged

yyoncho force-pushed the wf branch 2 times, most recently from cc6ac5f to 346a61e Compare December 17, 2018 17:27

yyoncho mentioned this pull request Dec 18, 2018

lsp-describe-thing-at-point should describe all documentation #555

Closed

yyoncho force-pushed the wf branch from 346a61e to 253d118 Compare December 19, 2018 06:49

yyoncho force-pushed the wf branch from 253d118 to a6236a4 Compare December 19, 2018 16:32

MaskRay approved these changes Dec 20, 2018

View reviewed changes

yyoncho force-pushed the wf branch 3 times, most recently from 3a43580 to 5b589b9 Compare December 20, 2018 19:25

yyoncho added 2 commits December 20, 2018 21:34

Temporary comment flymake errors/warnings/info handling

7ef8a34

- in some cases the lightner of flymake does not display the correct count

yyoncho force-pushed the wf branch from 5b589b9 to 7ef8a34 Compare December 20, 2018 19:35

yyoncho merged commit 7803af2 into emacs-lsp:master Dec 20, 2018

yyoncho added a commit to emacs-lsp/lsp-ui that referenced this pull request Dec 20, 2018

LSP UI changes needed to make signature support work on lsp-ui side (#…

26bb3c3

…211) Fixes #204 Requires: emacs-lsp/lsp-mode#544

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve session folder handling and added events for handling them #544

Improve session folder handling and added events for handling them #544

yyoncho commented Dec 14, 2018 •

edited

Loading

MaskRay commented Dec 15, 2018

yyoncho commented Dec 15, 2018

yyoncho commented Dec 15, 2018

MaskRay Dec 17, 2018

yyoncho Dec 17, 2018

MaskRay Dec 18, 2018

MaskRay Dec 18, 2018

MaskRay Dec 17, 2018

yyoncho Dec 17, 2018

MaskRay Dec 17, 2018

yyoncho Dec 17, 2018

MaskRay Dec 17, 2018 •

edited

Loading

yyoncho Dec 17, 2018

MaskRay Dec 17, 2018

yyoncho Dec 17, 2018

MaskRay Dec 18, 2018

yyoncho Dec 18, 2018

MaskRay Dec 17, 2018

yyoncho Dec 17, 2018

MaskRay Dec 17, 2018

yyoncho Dec 17, 2018

MaskRay Dec 18, 2018

yyoncho Dec 18, 2018

yyoncho commented Dec 19, 2018

Improve session folder handling and added events for handling them #544

Improve session folder handling and added events for handling them #544

Conversation

yyoncho commented Dec 14, 2018 • edited Loading

MaskRay commented Dec 15, 2018

yyoncho commented Dec 15, 2018

yyoncho commented Dec 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MaskRay Dec 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yyoncho commented Dec 19, 2018

yyoncho commented Dec 14, 2018 •

edited

Loading

MaskRay Dec 17, 2018 •

edited

Loading