-
-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nixd support #4125
Add nixd support #4125
Conversation
@@ -87,6 +87,27 @@ | |||
:synchronize-sections '("nil") | |||
:server-id 'nix-nil)) | |||
|
|||
(defgroup lsp-nix-nixd nil | |||
"LSP support for Nix, using nil." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably you meant nixd
here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apart from a minor comment.
Can we change that comment please and merge this? I'd love to have nixd in emacs lsp-mode |
Can you rebase this? Thanks! Anyway, you might want to use #4089 as a reference. Changelog, |
Adds a section to [editor-setup.md](https://github.com/nix-community/nixd/blob/main/docs/editor-setup.md) that adds guidance on making nixd work with Emacs. When emacs-lsp/lsp-mode#4125 (or another PR that adds nixd) is merged, this section should be changed.
Can you move this to a separate file? |
@colonelpanic8 is this something you still want to pursue? I can take over if not. :) |
Yeah go ahead! |
@colonelpanic8 seems like it's already done Thanks, @peterbecich. Could one of the mods, close this issue? @psibi ? |
@KarthikNayak Can you move it to a separate file as requested by Ivan in the thread ? |
Ah, I see what you mean. It was in a different PR. Closing this. |
No description provided.