Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWK language server support #4089

Merged
merged 1 commit into from
Jul 15, 2023
Merged

Add AWK language server support #4089

merged 1 commit into from
Jul 15, 2023

Conversation

Hi-Angel
Copy link
Contributor

@Hi-Angel Hi-Angel commented Jul 4, 2023

Implements the following wishlist item.

@github-actions github-actions bot added documentation client One or more of lsp-mode language clients labels Jul 4, 2023
jcs090218
jcs090218 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@jcs090218 jcs090218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Hi-Angel
Copy link
Contributor Author

Thank you for reviewing! Given it's been approved, can it be merged? I am waiting for the PR so I can send documentation changes to awk-language-server where it would say that lsp-mode supports it automatically. I can send now a way to configure it manually, but would be good to avoid sending documentation fixes twice.

@Hi-Angel
Copy link
Contributor Author

Ping

@yyoncho yyoncho merged commit 5550e12 into emacs-lsp:master Jul 15, 2023
@Hi-Angel
Copy link
Contributor Author

Thank you! Sending the docs to awk-language-server as well 👍

@jcs090218 jcs090218 mentioned this pull request Aug 31, 2023
Merged
@jcs090218 jcs090218 mentioned this pull request Sep 13, 2023
Merged
@jcs090218 jcs090218 mentioned this pull request Oct 5, 2023
Closed
@jcs090218 jcs090218 mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyoncho yyoncho yyoncho approved these changes

@jcs090218 jcs090218 jcs090218 approved these changes

Assignees
No one assigned
Labels
client One or more of lsp-mode language clients documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hi-Angel @jcs090218 @yyoncho