Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1818 Enable jest-enzyme tests using React 17 adapter #1819

Merged

Conversation

nmgokhale
Copy link
Member

@nmgokhale nmgokhale commented Apr 3, 2024

Fixes: #1818

Test Suites: 124 passed, 124 total
Tests:       7 skipped, 1482 passed, 1489 total
Snapshots:   0 total
Time:        55.449 s

7 Tests are skipped with following reasons -

All of these tests should be enabled during migration to RTL.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@nmgokhale nmgokhale self-assigned this Apr 3, 2024
@nmgokhale nmgokhale marked this pull request as draft April 3, 2024 00:07
@@ -93,14 +93,15 @@ describe("dm condition operators work correctly", () => {
dropdownButton.simulate("click");
dropdownList.at(3).simulate("click"); // Fulfill Condition by selecting item with dmRole discrete
errorMessages = controller.getErrorMessages();
expect(errorMessages).to.deep.equal({});
// TODO: this works in the UI but errorMessages is not updated in test
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test works in UI but controller.getErrorMessages() is not updated after wrapper.update().

@nmgokhale nmgokhale marked this pull request as ready for review April 5, 2024 21:56
@nmgokhale nmgokhale requested a review from matthoward366 April 5, 2024 21:56
Copy link
Member

@matthoward366 matthoward366 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nmgokhale nmgokhale merged commit 62a988f into elyra-ai:main Apr 8, 2024
3 checks passed
@nmgokhale nmgokhale deleted the enable-jest-tests-using-React17-adapter branch April 8, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable enzyme tests using React 17 adapter
2 participants