[Bug]: [NumberInput] Can't enter negative numbers

[nmgokhale]

Package

@carbon/react

Browser

Chrome

Package version

1.53.0

React version

18.2.0

Description

I can't type negative numbers (eg. -1) in the NumberInput field. Also when I want to remove all digits, number input is set to 0. Even after setting allowEmpty.

Following screen recording from v10 (https://v10.carbondesignsystem.com/components/number-input/code/#live-demo) no longer works in v11 -

Screen.Recording.2024-03-16.at.3.44.20.PM.mov

Reproduction/example

https://react.carbondesignsystem.com/?path=/story/components-numberinput--playground

Steps to reproduce

Please see description

Suggested Severity

Severity 2 = User cannot complete task, and/or no workaround within the user experience of a given component.

Application/PAL

No response

Code of Conduct

• I agree to follow this project's Code of Conduct
• I checked the current issues for duplicate problems

[afkoziol]

I was just looking into an e2e test failure of ours and it was a result of not being able to empty the input to enter a new number. The zero gets in the way, probably not desirable UX. I believe this was introduced with #15739

Thanks

[ecrvich]

I discovered myself today that allowEmpty has no effect. Maybe consider only zero-filling if the input is empty after focus is lost? Kind of annoying to do it while the user is still typing, and leading zeros suggest octal format to plenty of folks. FWIW in form use, that leading zero DOES of course get passed to the back end intact, so how it's interpreted depends on how the string is converted to a number on that end.

[hollyos]

@nmgokhale I tested this in the live demo and Storybook. It works in both instances. This issue was likely due to the min value equaling 0. The input allows for negatives when min is updated to a negative value.

@nmgokhale & @ecrvich The empty input is fixed in my PR (#16100)

@2nikhiltom, here's a heads-up that I put up a PR (#16100) for this issue (since you're self-assigned).